Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCov added #668

Merged
merged 7 commits into from
Feb 13, 2014
Merged

SimpleCov added #668

merged 7 commits into from
Feb 13, 2014

Conversation

corny
Copy link
Contributor

@corny corny commented Feb 11, 2014

SimpleCov is a code coverage analysis tool that generates awesome reports after running our test suite.
The Report can be found at /coverage/index.html.

corny and others added 2 commits February 11, 2014 01:45
SimpleCov is a code coverage analysis tool that generates awesome reports after running our test suite.
This also includes a SharedHelper to share
some settings between test_helper and spec_helper.
@0robustus1
Copy link
Contributor

On my system i have a problem with displaying gems in my gemset inside of simplecov-results.
8020ba6 should fix this.

@0robustus1
Copy link
Contributor

I'm not entirely sure about this, but we should probably also filter out results for files inside the
spec/ and test/ directories (tests themselves and factories).

@corny
Copy link
Contributor Author

corny commented Feb 11, 2014

On my system SimpleCov already excludes the spec/ and test/ directories. Do you get a different result?

@0robustus1
Copy link
Contributor

Yep i get output for every ruby file in test/ and spec/ including every test and factory.

@0robustus1
Copy link
Contributor

I would also suggest to setup groups (see here) for better readibility.

corny and others added 4 commits February 12, 2014 11:07
config, spec und test directories filtered
When coveralls is not used (rake task) we should
still generate local simplecov reports.
@0robustus1
Copy link
Contributor

c93652c should allow local generation of simplecov reports.

If that is alright (otherwise revert my commit), i'd say this can be merged 👍

@corny
Copy link
Contributor Author

corny commented Feb 12, 2014

I renamed the rake task test_with_coveralls into test:coveralls. After my last change Coveralls is only loaded if the rake task is invoked.

nning added a commit that referenced this pull request Feb 13, 2014
@nning nning merged commit 1d5e91b into staging Feb 13, 2014
@nning nning deleted the simplecov branch February 13, 2014 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants