642 add all sentences view #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combined_sentences method will fetch all sentences, own and imported ones. This also includes the imported_ontologies method, which works as the name suggests.
This includes the Helper (view and controller) to determine if we want to see all (logics or sentences for example) or only a subset.
| to_display_all_sentences: | ||
| to display all related sentences. | ||
| defined_in: | ||
| defined in %{link} |
There was a problem hiding this comment.
I would sort these labels into a sentences hierarchy...
This module utilizes a new layout model for the graph-like structure-fetchers. Later on (during *make fois version more stable*) we should restructure the graph_data_fetcher into this new layout.
|
Changes Unknown when pulling 3217a5d on 642-add_all_sentences_view into * on staging*. |
|
Changes Unknown when pulling 6a23d1f on 642-add_all_sentences_view into * on staging*. |
|
👍 |
Conflicts: config/locales/en.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall solve #642 by allowing to switch between a view which only displays the sentences which are defined by the ontology we are currently viewing (default, and it is the same as we had before), and a view which displays all sentences.
All sentences are defined as the union of self-defined sentences and the sentences which are defined
by all imported ontologies.
As a further gimmick we display the defining ontology next to the sentence (unless it is the ontology we are currently viewing).