748 using tarjan for entitytree #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 29, 2014 12:27
Conflicts: app/models/ontology.rb
| subclasses.each do |s| | ||
| c1, c2 = s.hierarchical_class_names | ||
|
|
||
| child = ontology.entities.where('name = ? OR iri = ?', c1, c1).first.id |
There was a problem hiding this comment.
- Here, the indentation is two spaces too far in (until line 17)
- Why not use
first!(also in next line)? If there is no such entity, you get a better error message withfirst!.
| t.text :name | ||
|
|
||
| t.timestamps | ||
| end |
There was a problem hiding this comment.
https://github.com/ontohub/ontohub/pull/805/files#Constraints are missing completely. Please add NOT NULL and FOREIGN KEY constraints. Indices are missing as well.
added 5 commits
April 4, 2014 12:25
|
@corny any signoff-news? |
| end | ||
|
|
||
| end | ||
| end |
There was a problem hiding this comment.
Indentation and vertical spacing is ugly, here.
|
👍 |
|
We decided on already merging this in the meeting. |
nning
added a commit
that referenced
this pull request
May 2, 2014
Using tarjan for entitytree, fixes #748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Tarjan algorithm for grouping the nodes of the entity trees to handle cycles in the class hierachy. See #748.