863 adjust hets version checking #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the hets-version checking to check for a version string like this: v0.99, 1402678179 Also change the way the method complains about non-matching versions. Versions which are are lesser than (through lexicographical comparison) the target string will still raise the VersionOutdated error but versions which fall through the regex-check (non-compatible) will only produce warnings in the log and on STDERR instead of killing the application.
This effectively bumps the minimal version by 60 commits.
|
Changes Unknown when pulling 79ce52b on 863-adjust_hets_version_checking into * on staging*. |
|
👍 |
0robustus1
added a commit
that referenced
this pull request
Jun 16, 2014
863 adjust hets version checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've adjusted the version checking to the new schema.
This also changes the complain mechanism, in the future tests shouldn't fail just because the ubuntu-package
reports a version that is incompatible with the one provided inside the yml-file.
Also the hets-formula (homebrew for Mac OS X has been updated), feel free to update your hets version.
Take a look here for instructions.