Changed implementation of FlattenLens to no longer support extracting object elements #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c JSON element keys (instead, a BasicLens should be added manually above it)
bcogrel
approved these changes
Mar 21, 2023
DRovara
pushed a commit
that referenced
this pull request
Jul 12, 2023
Changed implementation of FlattenLens to no longer support extracting object elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If new columns are to be added from JSON object elements, this should now be done using a BasicLens above the FlattenLens. Instead, the FlattenLens now just adds one new column (name given in definition) that contains the flattened entries.
Also changed all existing test cases so that they conform to the new way of defining FlattenLenses.