Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new DateTime functions #705

Merged
merged 188 commits into from Jul 13, 2023
Merged

Added new DateTime functions #705

merged 188 commits into from Jul 13, 2023

Conversation

DRovara
Copy link
Collaborator

@DRovara DRovara commented Jul 12, 2023 •
edited by bcogrel

Added support for the following new DateTime SPARQL functions:

  • dateTrunc
  • week-from-dateTime, quarter-from-dateTime... (decade, century, millennium, milliseconds, microseconds)

Regarding dateTrunc:
Format:

obdaf:dateTrunc(date: xsd:dateTime, date-part: xsd:string) -> xsd:dateTime`

Not all granularities are supported by all dialects.
Only constants are supported for the date-part parameter.

Regarding extraction functions:
Not all granularities are supported by all dialects, but I implemented alternative approaches to extract all granularities anyways.

Prefix obdaf: <https://w3id.org/obda/functions#>

bcogrel and others added 30 commits February 20, 2023 18:17
@bcogrel
Merge branch 'releasing/v5.0' into version5
a5b4fde
@bcogrel
Update property_description.json
2fe9dbf
@DRovara
Changed UnionNodeImpl inferUniqueConstraints method to add disjoint c…
6a6d6da 
…olumns to unique constraints if they exist, when they are necessary.
@DRovara
Initial version of UnionTest with some basic tests
0ebb4eb
@kontchakov
Merge branch 'version5' into feature/substitution-refactoring
e1079f5
@bcogrel
Merge branch 'releasing/v5.0' into version5
e70c100
@bcogrel
Merge branch 'releasing/v5.0' into version5
a0ccc82
@DRovara
Added more testcases for UnionLens, fixed bug that sometimes didn't r…
18618f1 
…ecognize union relations were different, added AddForeignKey support for union lens
@kontchakov
Merge branch 'version5' into feature/substitution-refactoring
435c9bd
@DRovara
Cleanup in code
a40ec73
@DRovara
Removed unused variable
62708b1
@DRovara
Changed some test case expected results that were outdated with the n…
6e3f7b0 
…ew version of unique constraint inference for UnionNodes
@DRovara
Changed UnionNode implementation so that unique constraints only add …
adfee7e 
…disjoint columns if they are not already unique by themselves. Also removed unnecessary warning from JsonUnionLens
@DRovara
Simplified inferUniqueConstraints method in UnionNode
effc476
@DRovara
Changed comments in inferUniqueConstraints
6824db2
@kontchakov
reduced interface inclusions and cleaned up a raw type
21b8a34
@DRovara
Added shortcut to inferUniqueConstraints: if all UCs are disjoint, we…
7c9ec17 
… do not need to compute disjoint variables
@bcogrel
Merge branch 'feature/union-lens' of github.com:DRovara/ontop into DR…
7229804 
…ovara-feature/union-lens
@bcogrel
Merge branch 'DRovara-feature/union-lens' into version5
777b689
@kontchakov
Merge branch 'version5' into feature/substitution-refactoring
5349a4e
@kontchakov
JsonUnionLens revision
51c83b3
@kontchakov
Merge branch 'feature/substitution-refactoring' into version5
8cd54bb
@bcogrel
Merge branch 'releasing/v5.0' into version5
e6daf13
@bcogrel
Normalizer updated to use Substitution instead of ImmutableSubstitution.
7b00abb
@bcogrel
Merge branch 'releasing/v5.0' into version5
14ff3e6
@DRovara
Implemented new FlattenLens that no longer supports access of specifi…
95fe2df 
…c JSON element keys (instead, a BasicLens should be added manually above it)
@DRovara
Implemented FlattenLens support for SparkSQL. Also added new type of …
3b150e0 
…lightweight tests for nested data structure access
@DRovara
Merge branch 'feature/flatten-lens-refactoring' into feature/flatten-…
6bd6533 
…lens-spark-new
@DRovara
Applied new FlattenNode logic to Spark
178f2fc
@DRovara
Initial implementation of using the ARRAY<T> type in Spark for the Fl…
091cc36 
…attenLens (currently hardcoded to ARRAY<STRING>, should be made generic)
DRovara and others added 14 commits June 1, 2023 09:59
@DRovara
Possibly fixed postgres issue
9280ed3
@DRovara
Disabled non-supported test case for MySQL and MariaDB
be3f79e
@DRovara
Disabled non-supported test case for MySQL and MariaDB
4e60af2
@DRovara
Fixed test case for trino
7aafc7a
@DRovara
Fixed test case for trino
58c94fe
@DRovara
Distinguished intermediate functions for date_trunc and timestamp_trunc
b087764
@DRovara
Distinguished intermediate functions for date_trunc and timestamp_trunc
78594f1
@DRovara
Reworked date_trunc function symbol
8554da2
@DRovara
Reworked date_trunc function symbol
cebe78c
@DRovara
Fixed dremio test case
3c2f1a0
@DRovara
Merge branch 'feature/new-datetime-functions' of https://github.com/o…
a05b35a 
…ntop/ontop into feature/new-datetime-functions
@DRovara
<Merge branch 'version5' into feature/new-datetime-functions
f779fd1
@DRovara
Fixed datetrunc issues that were caused by merge
7e8cb67
@DRovara
Fixed Trino problem caused by merge, fixed error in dremio test case
77e5c1b
@DRovara DRovara self-assigned this Jul 12, 2023
@DRovara DRovara requested a review from bcogrel July 12, 2023 14:03
@bcogrel bcogrel added this to the v5.1.0 milestone Jul 13, 2023
@bcogrel bcogrel marked this pull request as ready for review July 13, 2023 14:13
@bcogrel bcogrel merged commit cc3747b into version5 Jul 13, 2023
16 checks passed
@bcogrel bcogrel deleted the feature/new-datetime-functions branch July 13, 2023 15:40
@bcogrel
Copy link
Member

bcogrel commented Jul 13, 2023

Thanks Damian, great features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcogrel bcogrel bcogrel approved these changes

Assignees

@DRovara DRovara

Labels
status: fixed type: enhancement w: sparql function
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DRovara @bcogrel @kontchakov @apano-on @fracorco