Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Old Version SQLServer LimitOffset normalization #721

Merged
merged 1 commit into from Jul 29, 2023

Conversation

DRovara
Copy link
Collaborator

@DRovara DRovara commented Jul 28, 2023

Previously, the Limit and Offset normalizer for old versions of SQLServer did not apply the transformation to subqueries in case they contain another slice node.

Because of that, complex queries failed on old versions of SQLServer.

This pull request fixes this issue.

@DRovara DRovara added this to the v5.1.0 milestone Jul 28, 2023
@bcogrel bcogrel merged commit 706a290 into version5 Jul 29, 2023
32 checks passed
@bcogrel bcogrel deleted the bugfix/old-mssql-fix branch July 29, 2023 12:25
@bcogrel
Copy link
Member

bcogrel commented Jul 29, 2023

Thanks Damian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants