Implemented option to expose system tables #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem tables to follow the standard procedure (using the method
…ystem tables can also be shown, if requested
… all other dialects as well
bcogrel
approved these changes
Aug 22, 2023
|
Thanks Damian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that system tables will be included in the list of relations accessible by Ontop, when the option
ontop.exposeSystemTablesis set totrue.Currently, system tables are marked as hidden by the method
isRelationExcludedin the corresponding metadata provider. Now, in addition to checking the output of this method, Ontop will also require that theexposeSystemTablesoption is set to false before hiding a table.Hiding system tables is currently not supported for: