forked from ontoportal/goo
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explanation why we need to change how the SPARQL queries #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes (broken by now)
…ed a lot by retrieving object when it is the case)
…ters (way easier than the other way btw...
…nd handle case when trying to set unmapped when parsing a submission
@@ -264,13 +291,108 @@ def self.model_load(*options) | |||
## | |||
# always a list of attributes with subject == id | |||
## | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here
This was referenced Jul 19, 2022
Implemented by ncbo#124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explanation of why we need to change how the SPARQL queries are built:
Example of a query built to get information of submissions 2 of the MO ontologies
If there is only a single value it is perfect, it returns a single result. But if there are multiple values for multiple attributes then the number of results is a multiplication of the number of values for each attribute
For example if we have 3 attributes with the following values:
attr1 = ["a1 value1", "a1 value2"]
attr2 = ["a2 value3", "a2 value4", a2 value5]
attr3 = ["a3 value6", "a3 value7"]
We will get the following results:
"a1 value1", "a2 value3", "a3 value6"
"a1 value1", "a2 value4", "a3 value6"
"a1 value1", "a2 value5", "a3 value6"
"a1 value2", "a2 value3", "a3 value6"
"a1 value2", "a2 value4", "a3 value6"
"a1 value2", "a2 value5", "a3 value6"
"a1 value1", "a2 value3", "a3 value7"
"a1 value1", "a2 value4", "a3 value7"
"a1 value1", "a2 value5", "a3 value7"
"a1 value2", "a2 value3", "a3 value7"
"a1 value2", "a2 value4", "a3 value7"
"a1 value2", "a2 value5", "a3 value7"
Here is the new query generated
And new query with inverse attributes: