Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2 support, bump to v1.0.1 #13

Merged
merged 5 commits into from
Feb 26, 2018

Conversation

Andrey-Skvortsov
Copy link
Contributor

@Andrey-Skvortsov Andrey-Skvortsov commented Feb 25, 2018

  • Add Django 2 compatibility
  • Bump to v1.0.1 (may be ready to move from alpha?) Also it needs to bump as some changes not in PyPi now.
  • Add function based field (would be useful when you need not a fix raw value but dynamically calculated, e.g. to join with language data in current active language)

@coveralls
Copy link

coveralls commented Feb 25, 2018

Coverage Status

Coverage increased (+0.02%) to 98.738% when pulling 7ac6b5f on Andrey-Skvortsov:add-django2-support into 33dcd17 on onysos:master.

Copy link
Collaborator

@ornoone ornoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good. nice work and IC config.

@ornoone
Copy link
Collaborator

ornoone commented Feb 26, 2018

@Andrey-Skvortsov do you want to write a small example in the doc for your FunctionBasedFieldValue before I merge and publish in pypi?

@Andrey-Skvortsov
Copy link
Contributor Author

@ornoone Added an example for FunctionBasedFieldValue

@Andrey-Skvortsov
Copy link
Contributor Author

@ornoone It's ready to merge and publish

Copy link
Collaborator

@ornoone ornoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ornoone ornoone merged commit 0adbe60 into onysos:master Feb 26, 2018
@ornoone
Copy link
Collaborator

ornoone commented Feb 26, 2018

@tomlemeuch can you upload it to pypi ? it seem the pypi package owner is Onysos.

@shun-liang
Copy link
Contributor

@ornoone @tomlemeuch I am interested about when there will be a release based on this commit. Can I ask for an ETA? Many thanks.

@tohugaby
Copy link
Contributor

tohugaby commented Mar 7, 2018

django-composite-foreignkey 1.01 uploaded on pypi.
@Andrey-Skvortsov thank you for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants