Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.x #3

Merged
merged 1 commit into from
Nov 14, 2017
Merged

0.11.x #3

merged 1 commit into from
Nov 14, 2017

Conversation

piranha
Copy link
Contributor

@piranha piranha commented Nov 7, 2017

This is a first step towards an updated onyx-http. There are three things which concern me:

  1. It does not really work. :-) Current test generates empty onyx.core/results inside of HttpOutput/write-batch method and I can't comprehend why.
  2. Thread/sleep for a backoff worries me a little - I'm not sure what's the right way to do this with manifold/aleph and I can't test until I fix first issue.
  3. General layout of code, what do you think?

@piranha
Copy link
Contributor Author

piranha commented Nov 7, 2017

It seems like it hangs on feedback-exception! forever... :\

@lbradstreet lbradstreet changed the base branch from 0.9.x to master November 7, 2017 19:07
@lbradstreet lbradstreet merged commit 99e271c into onyx-platform:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants