add grid rendering #7

Merged
merged 1 commit into from Aug 23, 2012

Conversation

Projects
None yet
2 participants
Contributor

JoeGermuska commented Aug 22, 2012

this works. A few things to consider:

maybe the --grid CLI option is redundant for ivtile since I don't know why you wouldn't always specify fields -- if you don't specify anything, no data is passed, so that seems useless. Still, it seems legal, so it seemed wise to allow people to publish the grids with no fields.

Also, the skip-if-exists code doesn't deal with the real possibility that the image exists but the JSON doesn't. It seemed complicated to refactor that to test one or the other. Perhaps the grid renderer should be independent of the image rendering, but that would be a different kind of refactor. I opted for reasonably expedient and someone else can do the next pull request!

onyxfish added a commit that referenced this pull request Aug 23, 2012

@onyxfish onyxfish merged commit dbc5491 into onyxfish:master Aug 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment