Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch driver process from egg working. #489

Merged
merged 2 commits into from
Jan 22, 2013
Merged

launch driver process from egg working. #489

merged 2 commits into from
Jan 22, 2013

Conversation

unwin
Copy link
Contributor

@unwin unwin commented Jan 22, 2013

bin/nosetests ion/agents/instrument/test/test_driver_process.py
Also will work with ion/services/sa/test/test_driver_egg.py once that code is brought in from Ian.

bin/nosetests ion/agents/instrument/test/test_driver_process.py
Also will work with ion/services/sa/test/test_driver_egg.py once that code is brought in from Ian.
elif not egg_name:
raise ServerError("egg_name for remotepath is %s'%s'" % (type(egg_name), egg_name))

return REPO_BASE + "/" + egg_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, REPO_BASE = 'http://sddevrepo.oceanobservatories.org/releases/' at the beginning of the file, line 369 will result in two '/' before the egg_name. Should we not have the REPO_BASE = 'http://sddevrepo.oceanobservatories.org/releases' ? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made requested change and pushed it to my fork.

On Jan 22, 2013, at 10:35 AM, swarbhanu notifications@github.com wrote:

In ion/agents/instrument/driver_process.py:

  •    log.debug("_egg_path")
    
  •    if not CACHE_DIR:
    
  •        raise ServerError("CACHE_DIR is %s'%s'" % (type(CACHE_DIR), CACHE_DIR))
    
  •    elif not egg_name:
    
  •        raise ServerError("egg_name for path is %s'%s'" % (type(egg_name), egg_name))
    
  •    return CACHE_DIR + "/" + egg_name
    
  • def _egg_remotepath(self, egg_name):
  •    log.debug("_egg_remotepath" + str(egg_name))
    
  •    if not REPO_BASE:
    
  •        raise ServerError("REPO_BASE is %s'%s'" % (type(REPO_BASE), REPO_BASE))
    
  •    elif not egg_name:
    
  •        raise ServerError("egg_name for remotepath is %s'%s'" % (type(egg_name), egg_name))
    
  •    return REPO_BASE + "/" + egg_name
    
    Since, REPO_BASE = 'http://sddevrepo.oceanobservatories.org/releases/' at the beginning of the file, line 369 will result in two '/' before the egg_name. Should we not have the REPO_BASE = 'http://sddevrepo.oceanobservatories.org/releases' ? Thanks.


Reply to this email directly or view it on GitHub.

wfrench pushed a commit that referenced this pull request Jan 22, 2013
launch driver process from egg working.

Smoke tests are passing on dev machines.
@wfrench wfrench merged commit 1618496 into ooici:master Jan 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants