Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle issue with ooni.torproject.org subdomains #790

Open
4 of 13 tasks
hellais opened this issue Jan 18, 2024 · 5 comments
Open
4 of 13 tasks

Handle issue with ooni.torproject.org subdomains #790

hellais opened this issue Jan 18, 2024 · 5 comments
Assignees
Labels
funder/otffoss2023-2024 ooni/devops Issues related to https://github.com/ooni/sysadmin priority/medium

Comments

@hellais
Copy link
Member

hellais commented Jan 18, 2024

What we should do on our end is:

  • Check every place where we mention *.ooni.torproject.org and replace it with *.ooni.org
    • Mobile app strings
    • Explorer
    • Run
    • Probe-desktop
    • Engine
    • test-lists-ui
    • documentation
    • website content
    • past research reports
    • More
  • Evaluate possible solutions for handling this in a cleaner way and assess impact
    • Tor will setup on their own infrastructure a 302 redirect. We should have in place something to check that it's working properly and notify us if it breaks (ensure URL paths are being rewritten, headers are being forwarded, etc.)
    • Implement tighter ACME configuration at the DNS level

See: https://gitlab.torproject.org/tpo/tpa/team/-/issues/41386#note_2979925
https://gitlab.torproject.org/tpo/tpa/team/-/issues/41455

@hellais
Copy link
Member Author

hellais commented Jan 26, 2024

@aanorbel can you look into where in the mobile app we reference anything that contains the string *.ooni.torproject.org and document the location and URL in this issue?

@majakomel can you do the same for frontend?

We should then update all the strings and write some tests to ensure the redirects work.

@aanorbel
Copy link

aanorbel commented Feb 8, 2024

Occurrences of '*.ooni.torproject.org' in Probe Android

Resolving occurrences found.

  • Update the probe-android repo to remove the description directory. This directory is out of sync and doesn't reflect what is available in Transifex or Google Play.
  • Replace the URL in the QA check list.

@aanorbel
Copy link

aanorbel commented Feb 9, 2024

Occurrences of '*.ooni.torproject.org' in Probe iOS

Resolving occurrences found.

  • Replace the URL in the QA check list.

@hellais
Copy link
Member Author

hellais commented Mar 6, 2024

@aanorbel thanks for looking into this!

It's not clear to me if these strings are actually used. You mentioned for Android that:

This directory is out of sync and doesn't reflect what is available in Transifex or Google Play

Does this also apply to iOS?

Can you clarify in which instances these links would be used and what we need to do in order to update the reference to the new links?

@aanorbel
Copy link

The links are not used in the description of OONI Probe Android but are present in .xlf files which are present in the repository. Deleting these files which have no consequence to the overall working of the repository would resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funder/otffoss2023-2024 ooni/devops Issues related to https://github.com/ooni/sysadmin priority/medium
Projects
None yet
Development

No branches or pull requests

3 participants