Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report/handlers): accept more semver versions #111

Merged
merged 10 commits into from
Sep 26, 2017
Merged

fix(report/handlers): accept more semver versions #111

merged 10 commits into from
Sep 26, 2017

Commits on Sep 26, 2017

  1. fix(report/handlers): accept more semver versions 

    The current problem we have, specifically, is that since v1.2.0 the
mobile apps emit full semver including also the build.

This requires several parts of our infrastructure to improve the
regexp being used so to validate also this kind of input.

See also: measurement-kit/measurement-kit#1388

An earlier version of this diff was blessed by @hellais on Slack and
since then I just changed comments.
    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    4d7e246 View commit details
    Browse the repository at this point in the history

  2. attempt to repair regress test

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    87c8b0c View commit details
    Browse the repository at this point in the history

  3. fix problem with keyboard and chair

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    03f1028 View commit details
    Browse the repository at this point in the history

  4. another approach

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    9e0eca4 View commit details
    Browse the repository at this point in the history

  5. improve over previous

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    ec91e00 View commit details
    Browse the repository at this point in the history

  6. also print pid after the event

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    9bb6db5 View commit details
    Browse the repository at this point in the history

  7. make sure it is killed

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    7852de5 View commit details
    Browse the repository at this point in the history

  8. Finish off PR

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    0b08f53 View commit details
    Browse the repository at this point in the history

  9. rewrite the test

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    dbf01b1 View commit details
    Browse the repository at this point in the history

  10. exchange the order of operations to avoid a race

    @bassosimone
    bassosimone committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    d09c1c5 View commit details
    Browse the repository at this point in the history