Flag all Signal msmts as failed #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoCeratto
force-pushed
the
flag-signal-failed
branch
from
ae567b3
to
c95054c
Compare
|
0.82~pr771-209 deployed on -test |
|
0.82~pr771-210 deployed on -test |
|
0.82~pr771-210 deployed on FSN |
hellais
reviewed
Nov 15, 2023
| tk = g_or(msm, "test_keys", {}) | ||
| if tk.get("failed_operation", True) or tk.get("failure", True): | ||
| scores["accuracy"] = 0.0 | ||
|
|
||
| try: | ||
| # https://github.com/ooni/probe/issues/2344 | ||
| tv = g_or(msm, "test_version", "0.0.0") | ||
| if parse_version(tv) < parse_version("0.2.3"): |
There was a problem hiding this comment.
This is not correct, the check should be <=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ooni/probe#2627