Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about limitations of the gen-ssl-key-cert #89

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Add note about limitations of the gen-ssl-key-cert #89

merged 1 commit into from
Apr 6, 2017

Conversation

hellais
Copy link
Member

@hellais hellais commented Jun 2, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 61.575% when pulling 63ea33f on add-note-to-script into 6bd4a24 on master.

@anadahz
Copy link
Contributor

anadahz commented Jun 2, 2016

I think it makes sense to makes this clear in the README documentation as well and perhaps add documentation on how one can test this without ooni-probe.

@anadahz anadahz mentioned this pull request Jun 29, 2016
Closed
@hellais
Copy link
Member Author

hellais commented Apr 5, 2017

Can we merge this? I think it's better than nothing.

@anadahz
Copy link
Contributor

anadahz commented Apr 6, 2017

Sure, merging.

@anadahz anadahz merged commit 03d738b into master Apr 6, 2017
@anadahz anadahz deleted the add-note-to-script branch April 6, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellais @coveralls @anadahz