Add links to test descriptions on measurement pages #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
hellais
reviewed
Jun 18, 2020
| @@ -43,7 +44,13 @@ const DetailsHeader = ({testName, runtime, notice}) => { | |||
| /> | |||
| </Box> | |||
| <Box ml={2}> | |||
| <Text fontSize={20}>{metadata.name}</Text> | |||
| <Link href={metadata.info} target='_blank'> | |||
There was a problem hiding this comment.
I now realised that the behaviour is that of opening it in a new window.
I don't think we should be doing that. If the user wants to open it in a new window they can alt-click on the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282