Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked to Arabic translation in EG report #288

Merged
merged 9 commits into from
Oct 3, 2019
Merged

Conversation

agrabeli
Copy link
Member

@agrabeli agrabeli commented Oct 1, 2019

No description provided.

@hellais
Copy link
Member

hellais commented Oct 2, 2019

According to the person who did the translation we need to fix:

  • all text should be RTL except curl results (see: Add rtl support for blog posts #289)
  • this sentence "مصر تحجب بي بي سي والحرة: التوسع في الرقابة على الإعلام وسط الاضطرابات السياسية" is the translation of title, we should remove it. you find it in the line blew "English: Egypt blocks BBC and Alhurra: Expanding media censorship amid political unrest"
  • this sentence "كتب: رامي رؤوف ، محمد الطاهر ، محمد طيطا ، أرتورو فيلاست ، ماريا زينو" is a translation of " Ramy Raoof, Mohamed El-Taher, Mohamed Tita, Arturo Filastò, Maria Xynou" we should remove it also.

I will not be able to do this soon, so anybody with spare cycles please pick this up.

@agrabeli
Copy link
Member Author

agrabeli commented Oct 2, 2019

@hellais I implemented the 2nd & 3rd items that you listed via my latest commit.

@hellais
Copy link
Member

hellais commented Oct 3, 2019

Hum I appears that the rtl support added in 42691c2 is breaking the code blocks.

I will see if there is something I can do to fix this.

@hellais
Copy link
Member

hellais commented Oct 3, 2019

Ok it should now be ok.

@moeltaher can you check if it looks OK to you here: https://5d95be7fb9cf870008c3f915--ooni.netlify.com/ar/post/2019-egypt-blocks-bbc-and-alhurra/

@moeltaher
Copy link
Contributor

moeltaher commented Oct 3, 2019 via email

@hellais hellais merged commit f12b923 into master Oct 3, 2019
@hellais hellais deleted the translation/eg-report branch October 3, 2019 10:10
@hellais
Copy link
Member

hellais commented Oct 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants