Update/mk #159
Merged
Update/mk #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
approved these changes
Nov 8, 2018
| software_name = "ooniprobe-android"; | ||
| software_version = VersionUtils.get_software_version(); | ||
| randomize_input = 0; | ||
| randomize_input = false; |
There was a problem hiding this comment.
So, no-one is using randomize_input. I'd like to get rid of it in MK. It sounds like extra complexity now.
| client.setNetworkType(network_type); | ||
| client.setPlatform("android"); | ||
| //TODO what to add here? | ||
| //client.setProbeFamily(String value); |
There was a problem hiding this comment.
We do not use this field presently.
| client.setPlatform("android"); | ||
| //TODO what to add here? | ||
| //client.setProbeFamily(String value); | ||
| client.setProbeTimezone(TimeZone.getDefault().getDisplayName(true, TimeZone.SHORT)); |
There was a problem hiding this comment.
Should be "UTC" or "CEST" or the short version that doesn't include the Country/City
There was a problem hiding this comment.
Unless this was discussed and I missed the discussion, I would suggest to include the Country/City because it is information useful to us. Isn't it?
| client.setSoftwareName(software_name); | ||
| client.setSoftwareVersion(software_version); | ||
| //TODO add @"web_connectivity", @"whatsapp", @"telegram", @"facebook_messenger", @"ndt", @"dash", @"http_invalid_request_line", @"http_header_field_manipulation" | ||
| //client.addSupportedTest(); |
There was a problem hiding this comment.
Yeah, I suggest doing that :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.