Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created exception utility #293

Merged
merged 2 commits into from Mar 6, 2020
Merged

Created exception utility #293

merged 2 commits into from Mar 6, 2020

Conversation

lorenzoPrimi
Copy link
Contributor

Fixes ooni/probe#983

Proposed Changes

  • Created a class called ExceptionManager that imports Crashlytics and sends crash to them.
    In this way if we decide to remove Crashlytics and use any other crash reporting system in the code, it will be a one line edit.

Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

Let's also open an issue regarding where to catch exceptions. It may be that we're catching them in too many places and, for sure, I have seen ameliorable code patterns throughout the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants