Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences fix #296

Merged
merged 4 commits into from Feb 28, 2020
Merged

Preferences fix #296

merged 4 commits into from Feb 28, 2020

Conversation

lorenzoPrimi
Copy link
Contributor

Fixes: ooni/probe#1024

The "hack" I was using to add a fake <Preference /> in the global preferences and replacing it at runtime with the "real" test settings with this code

if (getString(R.string.websites).equals(rootKey))
            setPreferencesFromResource(R.xml.preferences_websites, getArguments().getInt(ARG_CONTAINER_RES_ID), rootKey);

Caused ooni/probe#1018
so I removed this code and went for a clean approach with only one xml file for preferences.

I tried to split one single preference screen in multiple files without any luck, at the moment I would classify it as L/XL and we have other priorities.

Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@lorenzoPrimi lorenzoPrimi merged commit c8b43a2 into master Feb 28, 2020
@lorenzoPrimi lorenzoPrimi deleted the preferences_fix branch February 28, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants