Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ooni/probe#1024
The "hack" I was using to add a fake
<Preference />
in the global preferences and replacing it at runtime with the "real" test settings with this codeCaused ooni/probe#1018
so I removed this code and went for a clean approach with only one xml file for preferences.
I tried to split one single preference screen in multiple files without any luck, at the moment I would classify it as L/XL and we have other priorities.