Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Designs] Update OONI Run v1 UI to v2 #626

Merged
merged 7 commits into from Nov 24, 2023
Merged

[New Designs] Update OONI Run v1 UI to v2 #626

merged 7 commits into from Nov 24, 2023

Conversation

aanorbel
Copy link
Contributor

@aanorbel aanorbel commented Oct 24, 2023 •
edited

Fixes ooni/probe#2596

Proposed Changes

  • Update designs for Run v1 components to match new designs
  • Add SrtingListRecyclerViewAdapter to display List items
  • Convert OoniRunActivity to Kotlin
Light Dark
. .
web_connectivity_light web_connectivity_dark
web_connectivity_light_long_list web_connectivity_dark_long_list
web_connectivity_light_short_list web_connectivity_dark_short_list
http_header_field_manipulation_light http_header_field_manipulation_dark
invalid_light invalid_dark
outdated_light outdated_dark
whatsapp_light whatsapp_dark?

@aanorbel aanorbel marked this pull request as ready for review October 24, 2023 23:44
@aanorbel aanorbel changed the base branch from master to chore/gradle-kotlin-upgrade October 24, 2023 23:44
bassosimone
bassosimone requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

Thanks for modernizing the codebase!

We should make sure we address the merge conflict before merging: it seems something changed in the original OONI Run v1 class and we should make sure to carry forward what changed in the new kotlin code!

app/src/main/AndroidManifest.xml Show resolved Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/adapters/StringListRecyclerViewAdapter.kt Show resolved Hide resolved
Base automatically changed from chore/gradle-kotlin-upgrade to master November 3, 2023 07:33
@aanorbel aanorbel changed the base branch from master to dev/design-update November 24, 2023 14:07
@aanorbel aanorbel merged commit 997840c into dev/design-update Nov 24, 2023
5 checks passed
@aanorbel aanorbel deleted the issues/2596 branch November 24, 2023 14:08
@aanorbel aanorbel mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone requested changes

@hellais hellais Awaiting requested review from hellais

@jbonisteel jbonisteel Awaiting requested review from jbonisteel

@sloncocs sloncocs Awaiting requested review from sloncocs

Assignees
No one assigned
Labels
discuss invites discussion from contributors documentation enhancement ready for review testing ux
Projects
None yet
Milestone
No milestone
2 participants
@aanorbel @bassosimone