Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Designs] Update Chose websites view #630

Merged
merged 13 commits into from Dec 5, 2023
Merged

[New Designs] Update Chose websites view #630

merged 13 commits into from Dec 5, 2023

Conversation

aanorbel
Copy link
Contributor

@aanorbel aanorbel commented Oct 26, 2023 •
edited

Fixes ooni/probe#2592

Proposed Changes

  • Updated CustomWebsiteActivity to use new theme.
  • Change List item builder to use RecyclerView.

Tasks

  • Implement designs on light theme.
  • Convert list item builder to use RecyclerView.
  • Fix dark theme
  • Implement modal properly
Light Dark
Screenshot_20231104_110235) Screenshot_20231104_110254
Screenshot_20231104_110336 Screenshot_20231104_110407
Screenshot_20231104_110429 Screenshot_20231104_110441

Base automatically changed from chore/gradle-kotlin-upgrade to master November 3, 2023 07:33
@aanorbel aanorbel marked this pull request as ready for review November 4, 2023 10:06
@aanorbel aanorbel changed the base branch from master to dev/design-update November 24, 2023 14:11
bassosimone
bassosimone requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly 🐳. Maybe we need an issue for the TODO unless we want to address it as part of this pull request?

app/src/main/java/org/openobservatory/ooniprobe/activity/CustomWebsiteActivity.kt Outdated Show resolved Hide resolved
bassosimone
bassosimone approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 LGTM with minor suggestions

app/src/main/java/org/openobservatory/ooniprobe/activity/OverviewActivity.java Show resolved Hide resolved
...rc/main/java/org/openobservatory/ooniprobe/activity/customwebsites/CustomWebsiteViewModel.kt Show resolved Hide resolved
...penobservatory/ooniprobe/activity/customwebsites/adapter/CustomWebsiteRecyclerViewAdapter.kt Outdated Show resolved Hide resolved
...src/main/java/org/openobservatory/ooniprobe/activity/customwebsites/CustomWebsiteActivity.kt Show resolved Hide resolved
...src/main/java/org/openobservatory/ooniprobe/activity/customwebsites/CustomWebsiteActivity.kt Show resolved Hide resolved
aanorbel and others added 4 commits December 5, 2023 18:00
@aanorbel @bassosimone
Update app/src/main/java/org/openobservatory/ooniprobe/activity/custo…
64e778a 
…mwebsites/CustomWebsiteActivity.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
@aanorbel @bassosimone
Update app/src/main/java/org/openobservatory/ooniprobe/activity/custo…
dfe59e5 
…mwebsites/adapter/CustomWebsiteRecyclerViewAdapter.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
@aanorbel @bassosimone
Update app/src/main/java/org/openobservatory/ooniprobe/activity/custo…
c711ba6 
…mwebsites/CustomWebsiteActivity.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
@aanorbel
Update CustomWebsiteViewModel.kt
d7a16b1
@aanorbel aanorbel merged commit 706eef1 into dev/design-update Dec 5, 2023
3 of 5 checks passed
@aanorbel aanorbel deleted the issues/2592 branch December 5, 2023 17:24
@aanorbel aanorbel mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@jbonisteel jbonisteel Awaiting requested review from jbonisteel

@sloncocs sloncocs Awaiting requested review from sloncocs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aanorbel @bassosimone