Skip to content

Commit

Permalink
refactor: remove dnscheck loader (#1640)
Browse files Browse the repository at this point in the history
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [ ] reference issue for this pull request: <!-- add URL here -->
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

This diff refactors the dnscheck factory to use the default target
loader
  • Loading branch information
DecFox committed Aug 6, 2024
1 parent 2df2cab commit 26a49ca
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion docs/design/dd-008-richer-input.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
|--------------|------------------------------------------------|
| Author | [@bassosimone](https://github.com/bassosimone) |
| Last-Updated | 2024-07-02 |
| Reviewed-by | [@DecFox](https://github.com/DecFox |
| Reviewed-by | [@DecFox](https://github.com/DecFox) |
| Status | living document |

This document is a living document documenting our in-progress design
Expand Down
1 change: 0 additions & 1 deletion internal/registry/dnscheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func init() {
config: &dnscheck.Config{},
enabledByDefault: true,
inputPolicy: model.InputOrStaticDefault,
newLoader: dnscheck.NewLoader,
}
}
}

0 comments on commit 26a49ca

Please sign in to comment.