Skip to content

Commit

Permalink
chore(oonimkall): re-enable TestTaskRunnerRun (#1354)
Browse files Browse the repository at this point in the history
I have ran the test several times locally with `go test -race -count 1`
and it was working as intended. Either the CI run issue was just
temporary or it's something fundamental of the CI that I can't
reproduce.

For this reason, I am going to re-enable the test and see what happens.

Closes ooni/probe#2541
  • Loading branch information
bassosimone committed Oct 10, 2023
1 parent a694f7f commit 9d3b457
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/oonimkall/taskrunner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func TestMeasurementSubmissionFailure(t *testing.T) {
}

func TestTaskRunnerRun(t *testing.T) {
t.Skip("https://github.com/ooni/probe/issues/2541")
if testing.Short() {
t.Skip("skip test in short mode")
}
Expand Down Expand Up @@ -350,8 +349,7 @@ func TestTaskRunnerRun(t *testing.T) {
assertReducedEventsLike(t, expect, reduced)
})

t.Run(
"with InputOrStaticDefault policy and experiment with no static input",
t.Run("with InputOrStaticDefault policy and experiment with no static input",
func(t *testing.T) {
runner, emitter := newRunnerForTesting()
runner.settings.Name = "Antani" // no input for this experiment
Expand Down

0 comments on commit 9d3b457

Please sign in to comment.