Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTaskRunnerRun/with_success_and_max_runtime fails #2541

Closed
bassosimone opened this issue Sep 22, 2023 · 0 comments · Fixed by ooni/probe-cli#1354
Closed

TestTaskRunnerRun/with_success_and_max_runtime fails #2541

bassosimone opened this issue Sep 22, 2023 · 0 comments · Fixed by ooni/probe-cli#1354
Assignees
@bassosimone
Labels
bug Something isn't working needs investigation This issue needs extra data and investigation ooni/probe-engine priority/high releaseBlocker This issue blocks releasing

Comments

@bassosimone
Copy link
Contributor

Here's an excerpt from the logs:

2023/09/22 17:13:19 connection doesn't allow setting of send buffer size. Not a *net.UDPConn?. See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.
--- FAIL: TestTaskRunnerRun (3.00s)
    --- FAIL: TestTaskRunnerRun/with_succes_and_max_runtime (3.00s)
        taskrunner_test.go:248:   []oonimkall.eventKeyCount{
                ... // 5 identical elements      
                {Key: "status.progress", Count: 1},
                {Key: "status.report_create", Count: 1},
            +   {Key: "status.measurement_start", Count: 1},
            +   {Key: "status.progress", Count: 1},
            +   {Key: "measurement", Count: 1},
            +   {Key: "status.measurement_submission", Count: 1},
            +   {Key: "status.measurement_done", Count: 1},
                {Key: "status.measurement_start", Count: 1},
                {Key: "status.progress", Count: 1},
                ... // 9 identical elements      
              }

This issue is a release blocker.
@bassosimone bassosimone added bug Something isn't working priority/high needs investigation This issue needs extra data and investigation ooni/probe-engine releaseBlocker This issue blocks releasing labels Sep 22, 2023
@bassosimone bassosimone self-assigned this Sep 22, 2023
@bassosimone bassosimone mentioned this issue Sep 22, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 22, 2023
@bassosimone
refactor(enginenetx): make static/loadable policy easier to use (#1297)
039591e 
This diff makes the policy previously known as loadable and now know as
the static policy easier to use, by having a constructor that reads from
a key-value store and by passing it a fallback policy to use.

With this design, it should be possible to have code that uses the
static policy if applied, falling back to whatever policy we are
otherwise constructing into the NewNetwork constructor.

In a subsequent commit, I will hook this code into NewNetwork, so that
we can override the policy by changing the filesystem.

While there, notice several failures in the test suite and apply
workarounds (see ooni/probe#2539,
ooni/probe#2540,
ooni/probe#2541).

Part of ooni/probe#2531.
@bassosimone bassosimone changed the title TestTaskRunnerRun/with_succes_and_max_runtime fails TestTaskRunnerRun/with_success_and_max_runtime fails Oct 6, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 10, 2023
@bassosimone
chore(oonimkall): re-enable TestTaskRunnerRun
8f75b8c 
I have ran the test several times locally with `go test -race -count 1`
and it was working as intended. Either the CI run issue was just temporary
or it's something fundamental of the CI that I can'r reproduce.

For this reason, I am going to re-enable the test and see what happens.

Closes ooni/probe#2541
@bassosimone bassosimone mentioned this issue Oct 10, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 10, 2023
@bassosimone
chore(oonimkall): re-enable TestTaskRunnerRun (#1354)
9d3b457 
I have ran the test several times locally with `go test -race -count 1`
and it was working as intended. Either the CI run issue was just
temporary or it's something fundamental of the CI that I can't
reproduce.

For this reason, I am going to re-enable the test and see what happens.

Closes ooni/probe#2541
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor(enginenetx): make static/loadable policy easier to use (ooni…
d9f1366 
…#1297)

This diff makes the policy previously known as loadable and now know as
the static policy easier to use, by having a constructor that reads from
a key-value store and by passing it a fallback policy to use.

With this design, it should be possible to have code that uses the
static policy if applied, falling back to whatever policy we are
otherwise constructing into the NewNetwork constructor.

In a subsequent commit, I will hook this code into NewNetwork, so that
we can override the policy by changing the filesystem.

While there, notice several failures in the test suite and apply
workarounds (see ooni/probe#2539,
ooni/probe#2540,
ooni/probe#2541).

Part of ooni/probe#2531.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore(oonimkall): re-enable TestTaskRunnerRun (ooni#1354)
7293b50 
I have ran the test several times locally with `go test -race -count 1`
and it was working as intended. Either the CI run issue was just
temporary or it's something fundamental of the CI that I can't
reproduce.

For this reason, I am going to re-enable the test and see what happens.

Closes ooni/probe#2541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working needs investigation This issue needs extra data and investigation ooni/probe-engine priority/high releaseBlocker This issue blocks releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(oonimkall): re-enable TestTaskRunnerRun ooni/probe-cli
1 participant
@bassosimone