Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(all): improve SummaryKeys management #1491
refactor(all): improve SummaryKeys management #1491
Changes from 2 commits
d0bf708
8ee91e7
8b6ee89
6eaa97b
787509f
6568812
92609ce
33e163c
d3767dd
c70c189
ff42ca8
f97f05d
33862e6
d6db5d9
3e0e819
a3279f6
3091ad0
19b0375
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can safely remove this comment because we have moved the implicit requirement that every structure that implements summary MUST contain a field called
IsAnomaly
with boolean type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we implicitly provide the correct always-returning-false implementation when an experiment does not implement the
MeasurementSummaryKeysProvider
interface. So, we can safely zap the boilerplate code concerning the summary keys for each experiment that always returned false.