Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed riseupvpn test #171

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

cyBerta
Copy link
Contributor

@cyBerta cyBerta commented Nov 16, 2020

@cyBerta cyBerta changed the title [WIP] Exposed riseupvpn test Exposed riseupvpn test Nov 19, 2020
bassosimone added a commit to ooni/probe-engine that referenced this pull request Dec 4, 2020
bassosimone added a commit to ooni/probe-engine that referenced this pull request Dec 7, 2020
* feat(riseupvpn): fill test keys

Part of #1060.

Code adapted from ooni/probe-cli#171.

* fix(riseupvpn): more precise tests

* fix: remove now-wrong and rewritten test

* Update experiment/riseupvpn/riseupvpn.go
@cyBerta cyBerta changed the title Exposed riseupvpn test [WIP] Exposed riseupvpn test Dec 7, 2020
@cyBerta
Copy link
Contributor Author

cyBerta commented Dec 7, 2020

I'll update this PR now that the probe-engine includes already the summary test keys.

@bassosimone
Copy link
Contributor

bassosimone commented Dec 7, 2020

@cyBerta thank you! I moved the keys to probe-engine because, in general, we're trying to move most code that pertains to running tests to probe-engine. In #185, I've synced-up probe-cli to use the latest probe-engine.

BTW we have a plan for the next ~2 weeks to try and expose RiseupVPN in mobile and desktop: ooni/probe-engine#1060. So, I felt the need to accelerate merging the RiseupVPN test keys into probe-engine and releasing probe-engine to facilitate other's work in this space.

@cyBerta cyBerta changed the title [WIP] Exposed riseupvpn test Exposed riseupvpn test Dec 7, 2020
@bassosimone bassosimone merged commit 9192ead into ooni:master Dec 7, 2020
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants