Refactoring to reduce package count #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consolidate util and utils into the same package * Move internal/onboard into internal/cli/onboard * Move maybeOnboard into the onboard package
hellais
commented
Dec 2, 2019
| } | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This has just been moved into here from the separate onboarding package.
hellais
commented
Dec 2, 2019
| import ( | ||
| "github.com/ooni/probe-cli/nettests" | ||
| ) | ||
| package nettests |
There was a problem hiding this comment.
All nettests have been flattened into the root nettests package. I think eventually we should move all the nettest specific code into probe-engine as there is currently so many levels of indirection going on here.
There was a problem hiding this comment.
Yes, I believe we should aim for slowly moving code in probe-engine.
hellais
commented
Dec 2, 2019
| t.Fatal(err) | ||
| } | ||
| nt := HTTPInvalidRequestLine{} | ||
| ctl := NewController(nt, ctx, res) |
There was a problem hiding this comment.
This is a very basic smoke test.
bassosimone
approved these changes
Dec 4, 2019
| import ( | ||
| "github.com/ooni/probe-cli/nettests" | ||
| ) | ||
| package nettests |
There was a problem hiding this comment.
Yes, I believe we should aim for slowly moving code in probe-engine.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
Refactoring to reduce package count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am looking for in a review is:
No new code has been added (beyond adding new tests and code coverage checks).