Feature/boilerplate #853
Draft
Feature/boilerplate #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mechanical refactoring moves model.Engine to the model package. This changce is functional to subsequent changes to more easily generate and maintain existing experiments.
Like the previous commit, here the idea is to move things around in a mechanical fashion before working on more substantial changes.
Here the idea is that the logic for creating an experiment lives in
internal/registry along with a list of experiments.
In turn, this design will allow us soon to make it very easy to add a
new experiment, by making each experiment register itself.
However, before doing that, I need to refactor the code so that
each experiment and the engine can both import from registry.
+---------------+ +--------+
| An experiment | _| engine |
+---------------+ | +--------+
| |
| |
| +----------+ |
`----->| registry |<--. imports
imports +----------+
Once the above is possible, then each experiment can register itself.
This design allows us to automatically add new experiments by writing files in the proper package.
Also, make it opportunistic rather than measuring each time. So, we'll have some more measurements.
Conflicts: go.mod internal/measurexlite/trace.go
Conflicts: internal/measurexlite/conn.go internal/measurexlite/dialer.go internal/model/archival.go
9 tasks
1. adapt the template to allow for collecting the data we need 2. recognize that support for cookies is optional, so it should probably always be there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Please, insert here a more detailed description.