Skip to content

Commit

Permalink
psiphon: include max_runtime in results (#173)
Browse files Browse the repository at this point in the history
Suggested by @mirokuratczyk when we discussed the experiment
in a recent chat on Slack. Closes #153.
  • Loading branch information
bassosimone committed Dec 15, 2019
1 parent dfc06c4 commit a5e874e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions experiment/psiphon/psiphon.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ type TestKeys struct {
// Failure contains the failure that occurred.
Failure *string `json:"failure"`

// MaxRuntime is the number of seconds after which we
// interrupt the psiphon experiment.
MaxRuntime float64 `json:"max_runtime"`

// Requests contains HTTP measurements
Requests oodatamodel.RequestList `json:"requests"`

Expand Down Expand Up @@ -202,6 +206,7 @@ func (m *measurer) measure(
go m.printprogress(ctx, &wg, maxruntime, callbacks)
r := newRunner(m.config, callbacks)
measurement.TestKeys = r.testkeys
r.testkeys.MaxRuntime = maxruntime
err := r.run(ctx, sess.Logger)
cancel()
wg.Wait()
Expand Down

0 comments on commit a5e874e

Please sign in to comment.