dash: make sure failure is *string (#172)

Closes #146
ooni · Dec 15, 2019 · dfc06c4 · dfc06c4
1 parent b085006
commit dfc06c4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/experiment/dash/dash_otherwise.go b/experiment/dash/dash_otherwise.go
@@ -43,7 +43,7 @@ type Simple struct {
 // TestKeys contains the test keys
 type TestKeys struct {
 	Simple       Simple                      `json:"simple"`
-	Failure      string                      `json:"failure"`
+	Failure      *string                     `json:"failure"`
 	ReceiverData []neubotModel.ClientResults `json:"receiver_data"`
 }
 
@@ -161,12 +161,14 @@ func (tk *TestKeys) printSummary(logger log.Logger) {
 func (r *runner) do(ctx context.Context) error {
 	err := r.loop(ctx)
 	if err != nil {
-		r.tk.Failure = err.Error()
+		s := err.Error()
+		r.tk.Failure = &s
 		return err
 	}
 	err = r.tk.analyze()
 	if err != nil {
-		r.tk.Failure = err.Error()
+		s := err.Error()
+		r.tk.Failure = &s
 		return err
 	}
 	r.callbacks.OnProgress(1, "done")