[API CHANGE] Refactor code for fetching test lists #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. using a "client" for a test lists query is overkill, instead just have a single function with config and possibly result (the same concept can be applied to other places in the codebase, in which we create "client" instances we don't actually need) 2. make sure the toplevel API can be used from mobile code, i.e., avoid using a vector that gomobile cannot bind 3. verify, by looking at changed tests and miniooni, that the result API is still reasonably non-painful to use 4. make sure that the internal implementation details are part of the internal package: we're currently exposing too much internals These changes are yak shaving I implemented while starting the work to implement authenticated request for orchestra (i.e. #148)
|
I am going to merge with failing Travis because the failed build is useful to investigate #142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a "client" for a test lists query is overkill, instead just
have a single function with config and possibly result (the same
concept can be applied to other places in the codebase, in which we
create "client" instances we don't actually need)
make sure the toplevel API can be used from mobile code, i.e., avoid
using a vector that gomobile cannot bind
verify, by looking at changed tests and miniooni, that the result
API is still reasonably non-painful to use
make sure that the internal implementation details are part of the
internal package: we're currently exposing too much internals
These changes are yak shaving I implemented while starting the work
to implement authenticated request for orchestra (i.e. #148)