-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: build AAR and setup continuous integration #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create a new directory called MOBILE. This directory will contain two subdirs, both `gitignored`. We will put output packages inside the `dist` subdir. We will use the `gopath` subdir as the temporary gopath. The `go.sum` file changes slightly because we are using content from the `x/mobile` repository. We are however not compiling and building `gomobile` in a module enabled env to avoiding tainting `go.sum` and `go.mod` too much. We are in fact using a temporary gopath precisely for building `gomobile` outside of any module environment. This is part of measurement-kit/measurement-kit#1913 and specifically it contains the strategy to not need MK for running OONI on Android platforms. Of course, we are not at the point where we can get rid of MK completely yet, but already we have an AAR that implements some of our experiments.
bassosimone
changed the title
add build-android.bash: script to build AAR
Build AAR and setup continuous integration
Feb 19, 2020
bassosimone
changed the title
Build AAR and setup continuous integration
android: build AAR and setup continuous integration
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a new directory called MOBILE. This directory will
contain two subdirs, both
gitignored
. We will put outputpackages inside the
dist
subdir. We will use thegopath
subdir as the temporary gopath.
The
go.sum
file changes slightly because we are usingcontent from the
x/mobile
repository. We are however notcompiling and building
gomobile
in a module enabled envto avoiding tainting
go.sum
andgo.mod
too much. We arein fact using a temporary gopath precisely for building
gomobile
outside of any module environment.Also, there is a build that mimics what I am currently doing
on macOS, to validate we can still build for Android. The build
also produces the
.aar
and the sources as artefacts, e.g.see https://github.com/ooni/probe-engine/actions/runs/41802231.
These artefacts are stored at GitHub for 90 days,
which is good enough for the use case of downloading and
testing them. We will need a better and more comprehensive
solution when we build tags.
This is part of measurement-kit/measurement-kit#1913
and specifically it builds a replacement for MK on Android. Of course,
we are not at the point where we can get rid of MK completely yet, but already
we have an AAR that implements some of our experiments.