go1.15 workaround: add integration test and explanatory output #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just figured it's probably more transparent to inform the user running the build script that we're applying this workaround. Also, in readme_compiletimecheck.go, let us mention explicitly what is the build script that we could use for increased clarity. Related to #866.
We now have a workaround for people building using go1.15. We wanna make sure with a simple smoke test we produce a working miniooni binary. Also part of #866.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff contains a bunch of small cosmetic tweaks for #866 as well as a smoke test to make sure we're not going to break future builds of people using Go 1.15.