Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go1.15 workaround: add integration test and explanatory output #947

Merged
merged 2 commits into from
Sep 21, 2020
Merged

go1.15 workaround: add integration test and explanatory output #947

merged 2 commits into from
Sep 21, 2020

Commits on Sep 21, 2020

  1. build-cli.sh: say it when we apply workaround 

    I just figured it's probably more transparent to inform the user running
the build script that we're applying this workaround.

Also, in readme_compiletimecheck.go, let us mention explicitly what is
the build script that we could use for increased clarity.

Related to #866.
    @bassosimone
    bassosimone committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    3ee252a View commit details
    Browse the repository at this point in the history

  2. github/workflows: make sure we don't break go1.15 builds 

    We now have a workaround for people building using go1.15. We wanna make
sure with a simple smoke test we produce a working miniooni binary.

Also part of #866.
    @bassosimone
    bassosimone committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    afa0ae2 View commit details
    Browse the repository at this point in the history