Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: release 3.17.0 #2273

Closed
24 of 26 tasks
bassosimone opened this issue Sep 9, 2022 · 1 comment
Closed
24 of 26 tasks

cli: release 3.17.0 #2273

bassosimone opened this issue Sep 9, 2022 · 1 comment
Assignees
@bassosimone
Labels
chore routine tasks that must be done, but require little active brain power documentation Improvements or additions to documentation ooni/probe-cli ooni/probe-engine priority/medium technical task technical tasks e.g. deployment

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Sep 9, 2022 •
edited
Loading

  • oohttp: merge with upstream if needed
  • oocrypto: merge with upstream if needed
  • probe-cli: pin to the latest psiphon client-staging commit using go get -u -v
  • probe-cli: make sure go list ./cmd/ooniprobe does not include any pinned package in psiphon's go.mod
  • probe-cli: sync stunreachability targets with snowflake (see ./internal/stuninput)
  • probe-cli: take a look at go report card
  • probe-cli: ensure we're using latest version of several tools
  • probe-cli: ensure github.com/bassosimone/monorepo is using the latest version of several tools
  • probe-cli: update dependencies with go get -u -v -d ./...
  • probe-cli: ensure no dependency bumped its major version number using https://github.com/icholy/gomajor
  • probe-cli: update user-agent at internal/model/http.go
  • probe-cli: update github.com/ooni/probe-assets dependency
  • probe-cli: update bundled certs (using go generate ./...)
  • android: replace ooni/go-libtor with scripts compiling tor #2365
  • probe-cli: go test -race -count 1 ./... must pass locally
  • probe-cli: address any outstanding TODO in the diff since last release (or create an issue for it)
  • probe-cli: make sure all workflows are green
  • probe-cli: check warnings emitted by gosec runs
  • probe-cli: update internal/version/version.go
  • probe-cli: tag a new version
  • probe-cli: update internal/version/version.go to be alpha
  • probe-android: pin to latest oonimkall
  • probe-ios: pin to latest oonimkall
  • probe-desktop: pin to latest cli
  • debian: publish packages
  • probe: create issue for next routine release
@bassosimone bassosimone self-assigned this Sep 9, 2022
@bassosimone bassosimone mentioned this issue Nov 22, 2022
Closed
@bassosimone bassosimone added documentation Improvements or additions to documentation chore routine tasks that must be done, but require little active brain power technical task technical tasks e.g. deployment ooni/probe-cli ooni/probe-engine and removed triage labels Dec 8, 2022
@bassosimone bassosimone mentioned this issue Jan 4, 2023
Merged
bassosimone added a commit to ooni/oohttp that referenced this issue Jan 4, 2023
@bassosimone
feat: implement better integration tests
4ae2cae 
There's a need to write better integration tests for this repository.

In particular:

1. we need to have confidence that the JA3 signature produced
when using a uTLS client is different than the default one (i.e.,
can we be confident that it's possible to replace TLS?)

2. we need to have robust tests that do not depend onto external
services but only use localhost, so they don't break often.

Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 4, 2023
Merged
bassosimone added a commit to ooni/oohttp that referenced this issue Jan 5, 2023
@bassosimone
feat: implement better integration tests (#34)
6a399fd 
There's a need to write better integration tests for this repository.

In particular:

1. we need to have confidence that the JA3 signature produced when using a uTLS client is different than the default one (i.e., can we be confident that it's possible to replace TLS?)

2. we need to have robust tests that do not depend onto external services but only use localhost, so they don't break often.

Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 5, 2023
Merged
bassosimone added a commit to ooni/oohttp that referenced this issue Jan 5, 2023
@bassosimone
Merge pull request #35 from ooni/attempt-merge-stable
854a2b3 
chore: merge stable into main

We currently have two branches and two release trains. However, this is ~bad because it creates more maintenance burden. So, just reckon we're still using go1.18 and make sure main is basically stable with small changes.

So, https://github.com/ooni/oohttp/compare/6a399fd..899c58a contains this diff:

```diff
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
index 63678c6..dd75520 100644
--- a/.github/workflows/go.yml
+++ b/.github/workflows/go.yml
@@ -2,9 +2,9 @@ name: Go
 
 on:
   push:
-    branches: [ main, stable ]
+    branches: [ main ]
   pull_request:
-    branches: [ main, stable ]
+    branches: [ main ]
 
 jobs:
 
diff --git a/README.md b/README.md
index 8e75a95..18348d8 100644
--- a/README.md
+++ b/README.md
@@ -223,14 +223,14 @@ minor changes (e.g., updating docs) directly on the `main` branch.
 
 ```bash
 set -ex
-git checkout stable
+git checkout main
 git remote add golang git@github.com:golang/go.git || git fetch golang
-git branch -D golang-upstream golang-http-upstream merged-stable || true
+git branch -D golang-upstream golang-http-upstream merged-main || true
 git fetch golang
 git checkout -b golang-upstream go1.18.9
 git subtree split -P src/net/http/ -b golang-http-upstream
-git checkout stable
-git checkout -b merged-stable
+git checkout main
+git checkout -b merged-main
 git merge golang-http-upstream

 ```

Part of ooni/probe#2273
bassosimone added a commit to ooni/oohttp that referenced this issue Jan 5, 2023
@bassosimone
doc: make sure we provide accurate information
1913924 
Part of ooni/probe#2273
This was referenced Jan 5, 2023
Merged
Merged
bassosimone added a commit to ooni/oocrypto that referenced this issue Jan 5, 2023
@bassosimone
Merge pull request #12 from ooni/attempt-merge-stable
7946b0a 
chore: merge stable into main

Similar to ooni/oohttp#35

Part of ooni/probe#2273

You can check for yourself the diff between this branch and stable: https://github.com/ooni/oocrypto/compare/7020325..8dbbe22
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: use go1.18.9
4848d97 
With this diff we're setting GOVERSION to 1.18.9 and we're
importing oocrypto and oohttp using 1.18.9 as well.

Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 5, 2023
Merged
4 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: use go1.18.9 (#1012)
d2d6ff5 
* chore: use go1.18.9

With this diff we're setting GOVERSION to 1.18.9 and we're
importing oocrypto and oohttp using 1.18.9 as well.

Part of ooni/probe#2273

* fix: grammar
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: update dependencies
d9fc582 
See ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 5, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: update dependencies (#1013)
90c480f 
See ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
feat: integrate with psiphon using go.mod
6008cab 
Closes ooni/probe#2222

Part of ooni/probe#2273

Closes ooni/probe#2069
@bassosimone bassosimone mentioned this issue Jan 5, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
feat: integrate with psiphon using go.mod (#1014)
3ce3af7 
Closes ooni/probe#2222

Part of ooni/probe#2273

Closes ooni/probe#2069
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: run go generate ./...
b27576f 
See ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 27, 2023
@bassosimone
doc(buildtool): explain ANDROID_NDK_HOME for android gomobile
9c5fc06 
Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 27, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 27, 2023
@bassosimone
doc(buildtool): explain ANDROID_NDK_HOME for android gomobile (#1066)
9943cb0 
Part of ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 3, 2023
@bassosimone
chore: set version to 3.17.0-beta
213cb9a 
Part of ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 10, 2023
@bassosimone
cleanup(oonimkall): remove MaybeUpdateResources stub
6b0ad1c 
This diff ensures we remove in probe-cli all the functions we have
removed in ooni/probe-android#552.

Part of ooni/probe#2273.

Tested by recompiling the AAR and linking it into the Android app.
@bassosimone bassosimone mentioned this issue Feb 10, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 10, 2023
@bassosimone
cleanup(oonimkall): remove MaybeUpdateResources stub (#1080)
856f8d7 
This diff ensures we remove in probe-cli all the functions we have
removed in ooni/probe-android#552.

Part of ooni/probe#2273.

Tested by recompiling the AAR and linking it into the Android app.
bassosimone added a commit to ooni/probe-assets that referenced this issue Feb 13, 2023
@bassosimone
chore: use 2023-02 database
cc1dc9e 
Part of ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 13, 2023
@bassosimone
chore: use ooni/probe-assets@v0.15.0
fe0cca2 
Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Feb 13, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 13, 2023
@bassosimone
chore: use ooni/probe-assets@v0.15.0 (#1082)
d714b20 
Part of ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 13, 2023
@bassosimone
[backport] chore: use ooni/probe-assets@v0.15.0
4a43bf4 
This commit backports d714b20.

Part of ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 15, 2023
@bassosimone
feat(oohelperd): allow collecting CPU profiles
d562445 
This work is part of ooni/probe#2273. We are
performing QA to understand the oohelperd performance.
This was referenced Feb 16, 2023
Merged
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
chore: update to go1.19.6
8a1845e 
See ooni/probe#2273
@bassosimone bassosimone mentioned this issue Feb 16, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
chore: update to go1.19.6 (#1106)
764e762 
See ooni/probe#2273
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
[backport] chore: update to go1.19.6
39efa1d 
This commit backports 764e762.

See ooni/probe#2273
bassosimone added a commit to ooni/probe-desktop that referenced this issue Feb 16, 2023
@bassosimone
feat: upgrade to ooni/probe-cli@v3.17
b461d45 
Part of ooni/probe#2273
@bassosimone bassosimone mentioned this issue Feb 16, 2023
Closed
bassosimone added a commit to ooni/probe-ios that referenced this issue Feb 16, 2023
@bassosimone
feat: update to ooni/probe-cli@v3.17
5ccdc9e 
See ooni/probe#2273
@bassosimone bassosimone mentioned this issue Feb 16, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
feat(oohelperd): disable QUIC by default
0518480 
I have been eyeballing the performance charts for a few days and it
seems that enabling QUIC makes measurements slower.

The TH requires more time to complete. So, the probe can measure less
target URLs per run, given finite runtime constraints.

Measuring QUIC in the TH when the probe also measures QUIC is fine
because we obtain higher quality measurements.

However, now that most probes do not know about QUIC, it makes sense
to avoid measuring QUIC for them, so they continue to measure the
same number of URLs as before.

This diff belongs to the not-ever-small set of diffs authored when
doing pre-release QA. See ooni/probe#2273.
@bassosimone bassosimone mentioned this issue Feb 16, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
fix(oohelperd): disable QUIC by default (#1107)
7158cd6 
I have been eyeballing the performance charts for a few days and it
seems that enabling QUIC makes measurements ~slower.

The TH requires more time to complete. So, the probe can measure less
target URLs per run, given finite runtime constraints.

Measuring QUIC in the TH when the probe also measures QUIC is fine
because we obtain higher quality measurements.

However, now that most probes do not know about QUIC, it makes sense
to avoid measuring QUIC for them, so they continue to measure the
same number of URLs as before.

This diff belongs to the not-ever-small set of diffs authored when
doing pre-release QA. See ooni/probe#2273.
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 16, 2023
@bassosimone
[backport] fix(oohelperd): disable QUIC by default
64693ad 
This diff backports 7158cd6.

I have been eyeballing the performance charts for a few days and it
seems that enabling QUIC makes measurements ~slower.

The TH requires more time to complete. So, the probe can measure less
target URLs per run, given finite runtime constraints.

Measuring QUIC in the TH when the probe also measures QUIC is fine
because we obtain higher quality measurements.

However, now that most probes do not know about QUIC, it makes sense
to avoid measuring QUIC for them, so they continue to measure the
same number of URLs as before.

This diff belongs to the not-ever-small set of diffs authored when
doing pre-release QA. See ooni/probe#2273.
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 20, 2023
@bassosimone
chore: set version to 3.17.0
138b16f 
Part of ooni/probe#2273
@bassosimone
Copy link
Contributor Author

With ooni/probe-android@a756dbc, we can now consider this issue complete! 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
chore routine tasks that must be done, but require little active brain power documentation Improvements or additions to documentation ooni/probe-cli ooni/probe-engine priority/medium technical task technical tasks e.g. deployment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone