Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniooni: add support for setting software_name #2691

Closed
hellais opened this issue Mar 21, 2024 · 1 comment · Fixed by ooni/probe-cli#1544
Closed

miniooni: add support for setting software_name #2691

hellais opened this issue Mar 21, 2024 · 1 comment · Fixed by ooni/probe-cli#1544
Assignees
@bassosimone @hellais @DecFox
Labels
enhancement improving existing code or new feature ooni/probe-cli ooni/probe-engine priority/high

Comments

@hellais
Copy link
Member

hellais commented Mar 21, 2024

Currently miniooni does not support overriding the software_name field. It would be great if we could have the ability to override it like we do in ooniprobe so that people that need to use miniooni can set it to their own custom software_name.
@bassosimone
Copy link
Member

It seems this issue is actually priority/high and it should be completed ASAP. I am going to cut a new patch release ~tomorrow including this functionality inside of miniooni.

bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 4, 2024
@bassosimone
feat(miniooni): add --software-name and --software-version
bd06908 
Closes ooni/probe#2691
@bassosimone bassosimone mentioned this issue Apr 4, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 4, 2024
@bassosimone
feat(miniooni): add --software-name and --software-version (#1544)
a2a3c6a 
Closes ooni/probe#2691
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 5, 2024
@bassosimone
[backport] feat(miniooni): add --software-name and --software-version (…
294ce23 
…#1544)

Closes ooni/probe#2691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

@hellais hellais

@DecFox DecFox

Labels
enhancement improving existing code or new feature ooni/probe-cli ooni/probe-engine priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(miniooni): add --software-name and --software-version ooni/probe-cli
3 participants
@bassosimone @hellais @DecFox