Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oonimkall.HTTPRequest.URL is not passed properly from iOS #2701

Closed
aanorbel opened this issue Apr 8, 2024 · 0 comments · Fixed by ooni/probe-cli#1545
Closed

oonimkall.HTTPRequest.URL is not passed properly from iOS #2701

aanorbel opened this issue Apr 8, 2024 · 0 comments · Fixed by ooni/probe-cli#1545
Assignees
Labels
bug Something isn't working priority/high

Comments

@aanorbel
Copy link

aanorbel commented Apr 8, 2024

Clash Between Go Conventions and iOS Compatibility:

The Problem: Using "URL" in Go code breaks compatibility with iOS because iOS expects lowercase property names.

Possible Solution: Consider renaming the property to "Url" (lowercase) to match iOS expectations. This would sacrifice some consistency with Go conventions but ensure better compatibility.

@aanorbel aanorbel added bug Something isn't working triage labels Apr 8, 2024
@bassosimone bassosimone assigned aanorbel and unassigned bassosimone Apr 8, 2024
@bassosimone bassosimone removed the triage label Apr 8, 2024
bassosimone added a commit to ooni/probe-cli that referenced this issue Apr 8, 2024
Closes: ooni/probe#2701

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants