Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enginelocate: improve testing for ubuntu and cloudflare methods #2715

Closed
bassosimone opened this issue Apr 24, 2024 · 0 comments · Fixed by ooni/probe-cli#1564
Closed

enginelocate: improve testing for ubuntu and cloudflare methods #2715

bassosimone opened this issue Apr 24, 2024 · 0 comments · Fixed by ooni/probe-cli#1564
Assignees
@bassosimone

Comments

@bassosimone
Copy link
Member

As part of #2700, I am going to change the underlying mechanism with which we communicate with these services, by switching it from httpx to httpclientx (implemented in ooni/probe-cli#1560). Before making this change, I would like to boost our confidence about replacing the underlying mechanism by writing more comprehensive testing for the ubuntu and cloudflare IP lookup methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(enginelocate): improve ubuntu and cloudflare tests ooni/probe-cli
1 participant
@bassosimone