-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Run All Tests button #826
Comments
Moved to ooni/probe. @agrabeli please don't use app specific repo for a generic issue |
For what I understood the only UX needed here is how to manage the 4 tests in one screen.
I personally prefer the last solution, this can also be included in 2.1. |
Sorry, I missed this @lorenzoPrimi I prefer your last solution as well:
I'd need to think about a good place where to Run All Tests |
+1 to @elioqoshi and @lorenzoPrimi. Resetting the progress bar, when changing test, as well as changing background color and animation seems the ideal flow here. Do we want a new card on the Dashboard? I think we can include a new card at the end of the list. I was tempted to put it first, but it's better to promote a bulk test when users already have some experience using Probe before. Also, do we need to include any alert or disclaimer? I'm thinking about data consumption? Maybe, I'm overthinking it. What do you think? @agrabeli any suggestion for the description? |
Hi Antonela, I was probing probe. I feel an alert or disclaimer might not be necessary since it would be expected that the total bandwidth and time consumed in running all tests would be equal to the sum of both resources if they were run individually. Unless there's some extra resource requirement in running all of them, that info might be redundant. What would be nice is if there was a data usage estimate too. The middleware and instant messaging tests used exponentially less data than the websites one. |
Thanks @holantonela , that's a great suggestion! I think including a separate "Run All Tests" card at the end makes sense (at least as an interim solution -- anything else I can think of probably requires a more major UI revamp). I'll share the copy for this new card when I also work on the copy edits based on other tickets (within the relevant spreadsheet where we maintain strings). I agree with @aadibajpai that we probably don't need to include a disclaimer, but including a data usage estimate would be nice. @hellais @lorenzoPrimi do you think this would be feasible within the next releases? |
@holantonela What if instead of making a card (at the botton that would be really less visible) we make an header at the top (like 1/3 of a card size?) |
On second thought, I think I agree with @lorenzoPrimi 's suggestion (as having a "Run All Tests" card at the end would be less visible). Perhaps we could go with a header at the top per @lorenzoPrimi 's suggestion, or a "Run All Tests" button at the top? (I don't think we need copy for this, other than "Run All Tests") |
I agree that putting the Run all tests at the bottom would burry it a bit. What if we put the Run all tests card as the first card in the list? |
I would make it slimmer and with a style a bit different than a normal card. |
Why do you want a different style/size @lorenzoPrimi? |
Just to make it different as it's not a single test. And to leave more space for the cards. |
What do you need to move this forward @lorenzoPrimi? is there any blocker? |
From an UX point of view nothing is needed to make a mockup and see how it looks like. |
@holantonela I think it would be great if we could get a high resolution mockup of how this would look in the app. I guess the main things to figure out are:
I do also wonder, if to save up on a bit of vertical space and to make it clear that this is not yet another test, we should adjust the style of this to be a bit smaller and different from the rest of the cards. My concern is that by adding another card like that, the user will not be able to see what are all the tests they are about to run as half of the screen is taken up by a "Run all tests" card. |
Sure thing. Could you point me to the latest editable files? |
I can send them to you on the OONI Slack if you are there. Thanks a bunch! |
Thank you @hellais! So, I made the first attempt here
Let me know what the minimum height device you are considering is so we can contemplate a small size for all cards there. I don't think it makes sense to have a different card size for this one. |
Thanks for putting this together @holantonela ! I think it's OK, but I am still not too convinced by this choice as I think it takes up too much screen real-estate and it doesn't communicate very clearly that you are about to run all the cards and this is not different from the sum of all the rest of cards. What do you think of instead using a floating action button with the label "Run all tests"? I think this would do a better job at conveying the relationship between that action and the rest of the cards on the page. It also would be a bit more compact and not take up so much vertical space. |
Maybe the card could be smaller, but have a little triangle to expand a description? That way the description in the mockup would still be available, but it would be visually distinguished since it's smaller. |
FAB is a great idea if [Run all tests] is the main action in this screen. I have my doubts about it, but maybe it is a strong product move, and we are ok. I made a mockup to see how it looks Everybody here has strong feelings about making card smaller so I've tried that idea as well |
Yes I would say running all tests is the main action we would like users to run on this screen. This will ensure we have the best coverage for all the possible tests user can run.
Thanks for putting together this mockup. I think it works quite well. Some thoughts on things we could maybe improve are:
I am not a big fan of this option as I am not really convinced by the idea that "Run all tests" should be it's own card as logically it is actually an action performed on the set of all existing cards. |
Another element which I guess we should also consider in the designing a solution for this page, is that I think this impacts also the decision related to: #870. In there we are proposing to have a dedicated card just for allowing the user to pick which URL they would like to test. I think that if we don't go for the card option in this issue, we may want to also re-evaluate the other option too as the "Run all tests" primary action button would technically apply only to the "Automatic URL list", but not the "Manual URL list" and hence could be a bit confusing. @holantonela do you have some thoughts on this point or aspect? |
@hellais when scolling fully down the button shouldn't cover any card, there is some footer whitespace that allows the last card do be on top of the "Run all" button |
I documented the approach that I think we should take in relation to this issue, which applies both to this issue and #870 in the following comment: #870 (comment) |
We have received community requests to include a "Run All Tests" button in the revamped app (on both Android and iOS), to run all OONI Probe tests in sequence, by tapping one button (instead of having to manually run each test individually).
The text was updated successfully, but these errors were encountered: