Add slackin ansible role, fix docker pip version bugs #89
Conversation
|
We should add the |
|
The letsencrypt autorenewal on this role is not working. See: https://slack.openobservatory.org/ |
|
|
||
| - name: Check that Slackin website returns HTTP status 200 | ||
| uri: | ||
| url: https://{{ slackin_domains.split(' ')[0] }} |
There was a problem hiding this comment.
Where are variables defined? Can you, please, add slack_token to vault?
There was a problem hiding this comment.
Yes this role has been created and deployed long before the vault and now a number of things need to be changed. Feel free to give a hand and hopefully this can land in master sooner.
There was a problem hiding this comment.
Yes this role has been created and deployed long before the vault and now a number of things need to be changed. Feel free to give a hand and hopefully this can land in master sooner.
Merged master into this branch. You should now have vault support.
| - "{{ slack_irc_dir }}:/slack-irc" | ||
|
|
||
| - name: Wait for services to start | ||
| pause: minutes=1 |
There was a problem hiding this comment.
Is there anything wrong with wait_for ?
There was a problem hiding this comment.
There is nothing wrong with wait_for but wait for what specifically?
ansible/roles/slackin/tasks/main.yml
Outdated
| - name: Create slack-irc-bridge config | ||
| template: | ||
| src: config.json.secrets | ||
| dest: "{{ slack_irc_dir }}/config.json" |
There was a problem hiding this comment.
Why is configuration template secret?
There was a problem hiding this comment.
It contains the slack-irc-bridge bot credentials.
There was a problem hiding this comment.
yup, we should put it in the vault.
|
This role is now ansible vault compliant. |
|
LGTM! BTW did you ever figure out why the cert was not automatically renewed last time? |
The docker container of https-portal was unresponsive. |
| 32353036386431386365393164336139633232376337313831666635386665333830353932343538 | ||
| 38656465383838386262623765363538346533646635326637363161663362633138323436623335 | ||
| 65383736343665636563633633386636306661346236613337643265643639326162613831663138 | ||
| 336533656561376336376131643033303036 |
There was a problem hiding this comment.
@hellais did this PR work for you before merging? My ansible-2.2.2 considers this yaml malformed :(
ERROR! Syntax Error while loading YAML.
The error appears to have been in '.../ansible/host_vars/slack.openobservatory.org/vault': line 6, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
There was a problem hiding this comment.
My bad I was assuming it had been tested before being flagged as ready for review.
I checked and it seems that it contains in fact invalid YAML markup:
variable: |
{
"foo": "bar"
}
instead of:
variable: |
{
"foo": "bar"
}
I will push a fix to the integration branch.
|
^^ I moved the commit back to |
No description provided.