-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile scripts #6
Conversation
This reverts commit a9b1e97.
update_languages_android.sh
Outdated
@@ -0,0 +1,23 @@ | |||
#!/bin/bash | |||
source supported_languages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this after the check to see if you are in the correct directory and for sure after the set -e
so it exits when it fails to import it.
update_languages_android.sh
Outdated
set -e | ||
|
||
PROJDIR="../probe-android/" | ||
cd $PROJDIR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than changing directory, maybe it's best to use absolute paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would I do it? the cd is needed only for the -d check I guess
@@ -0,0 +1,26 @@ | |||
#!/bin/bash | |||
source supported_languages | |||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comments to above ^
update_languages_android.sh
Outdated
exit 1 | ||
fi | ||
|
||
cd ../translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you are changing directories again and making the assumption the current dir is called translations
, without checking that it's true.
No description provided.