Mobile scripts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9b1e97.
hellais
reviewed
Dec 17, 2018
update_languages_android.sh
Outdated
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
| source supported_languages | |||
There was a problem hiding this comment.
I would put this after the check to see if you are in the correct directory and for sure after the set -e so it exits when it fails to import it.
hellais
reviewed
Dec 17, 2018
update_languages_android.sh
Outdated
| set -e | ||
|
|
||
| PROJDIR="../probe-android/" | ||
| cd $PROJDIR; |
There was a problem hiding this comment.
Rather than changing directory, maybe it's best to use absolute paths?
There was a problem hiding this comment.
How would I do it? the cd is needed only for the -d check I guess
hellais
reviewed
Dec 17, 2018
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
| source supported_languages | |||
| set -e | |||
hellais
reviewed
Dec 17, 2018
update_languages_android.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| cd ../translations |
There was a problem hiding this comment.
Here you are changing directories again and making the assumption the current dir is called translations, without checking that it's true.
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.