Escape according to Canonical XML 1.0 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See <http://www.w3.org/TR/2000/WD-xml-c14n-20000119.html#charescaping>. First and foremost, this change allows adding linefeeds, tabs and carriage returns to attribute values. This was not possible before, since such characters did not get escaped and without escaping a conforming XML reader will replace them by blanks. [1] While at it, this change escapes attribute values, text, and comments according to the Canonical XML 1.0 specification. In particular, in attribute values greater-than and single quote no longer get escaped; in element values, single and double quotes no longer get escaped but carriage return does get escaped; and in comments, nothing gets escaped. [1] http://www.w3.org/TR/2004/REC-xml-20040204/#AVNormalize
oozcitak
added a commit
that referenced
this pull request
Aug 4, 2014
Escape according to Canonical XML 1.0
oozcitak
added a commit
that referenced
this pull request
Mar 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and foremost, this change allows adding linefeeds, tabs and carriage returns to attribute values. This was not possible before, since such characters did not get escaped and without escaping a conforming XML reader will replace them by blanks.
While at it, this change escapes attribute values, text, and comments according to the Canonical XML 1.0 specification. In particular, in attribute values greater-than and single quote no longer get escaped; in element values, single and double quotes no longer get escaped but carriage return does get escaped; and in comments, nothing gets escaped.