Windows support for chrome runner #2324
Conversation
|
The minitest failure is random I think, I re-ran the tasks. |
Its running faulty code |
|
Alright, for the others mspec-chrome / minitest-strict-chrome, i have no idea why it cant connect to chrome, i cant reproduce, maybe a timing issue? Or it too ran faulty code? No idea how and why that happens. |
|
Those errors are random and it's a known issue. |
|
We will merge it on Wednesday at the latest. |
lib/opal/cli_runners/chrome.rb
Outdated
| ] | ||
|
|
||
| Kernel.exec(*cmd) | ||
| end |
There was a problem hiding this comment.
If the windows solution is universal and can work on any system I'm in favor of only using that one, so we have less code to maintain and to reason about
lib/opal/cli_runners/chrome.rb
Outdated
| Process.kill('HUP', chrome_pid) if chrome_pid | ||
| case RbConfig::CONFIG['host_os'] | ||
| when /mswin|msys|mingw|cygwin|bccwin|wince|emc/ | ||
| Process.kill("KILL", pid) unless system("taskkill /f /t /pid #{pid} >NUL 2>NUL") |
There was a problem hiding this comment.
Is there a way to avoid the call to taskkill?
There was a problem hiding this comment.
No way. Windows has its weirdnesses and taskkill seems to be the best solution out there.
In a previous patchset (#2309, also fixing opal-repl on Windows) I tried running things on Windows and they ran smoothly. But I ran it via MSYS, and this patchset removes a need for MSYS. @janbiedermann had also a few test failures and he's ironing them out. I think the issue with a Windows action for mspec will be... that it will be very slow. Maybe we can consider just running the opal suite. |
- Use correct node separator for NODE_PATH on Windows - Pass dir and emulate exec a bit on Windows - Use Gem.win_platform?, match supported plattform to ruby, simplify run
No description provided.