Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong supertype for EventNotifierType in NodeSet2 #9

Closed
bjakke opened this issue Apr 24, 2018 · 2 comments
Closed

Wrong supertype for EventNotifierType in NodeSet2 #9

bjakke opened this issue Apr 24, 2018 · 2 comments

Comments

@bjakke
Copy link

bjakke commented Apr 24, 2018

The NodeSet 2 XML lists EventNotifierType as:

<UADataType NodeId="i=15033" BrowseName="EventNotifierType">
    <DisplayName>EventNotifierType</DisplayName>
    <References>
      <Reference ReferenceType="HasProperty">i=15034</Reference>
      <Reference ReferenceType="HasSubtype" IsForward="false">i=7</Reference>
    </References>
    <Definition Name="EventNotifierType" IsOptionSet="true">
      <Field Name="None" Value="0" />
      <Field Name="SubscribeToEvents" Value="1" />
      <Field Name="HistoryRead" Value="4" />
      <Field Name="HistoryWrite" Value="8" />
    </Definition>
  </UADataType>

Specification version 1.04, Part 3 section 8.59 lists the EventNotifierType as subtype of Byte DataType, however the NodeSet2 uses i=7 which is UInt32. The NodeSet2 should be fixed.

It should be noted that this is quite important and critical in my opinion, as the EventNotifierType is listed as the DataType of the EventNotifier Attribute for Objects in version 1.04 Part 3, section 5.5.1 Table 11. In 1.03 that was Byte, so if clients/servers are made using the current NodeSet2 for 1.04 they will not use the correct DataType (they would use incorrectly the UInt32 instead of Byte, as the encoded binary form) and are incompatible with all existing applications.

@bjakke
Copy link
Author

bjakke commented Apr 24, 2018

@opcfoundation-org
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants