This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(logger): fix publish loop #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, the logger's publish loop would be searching for a TCP connection. Since the logger runs on UDP, the publish loop would not find it running and would run forever. This changes netstat to search over UDP for the logger instead, allowing it to publish its values to etcd. fixes #738
|
LGTM. |
|
LGTM. |
bacongobbler
pushed a commit
that referenced
this pull request
Apr 18, 2014
fix(logger): fix publish loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, the logger's publish loop would be searching for a TCP connection. Since the logger runs on UDP, the publish loop would not find it running and would run forever. This changes netstat to search over UDP for the logger instead, allowing it to publish its values to etcd.
fixes #738
Surprisingly, as soon as I rebooted deis-logger (as well as usable-woodshed's logger) with this change, the application logs became available:
Also, I removed the occurrence of tabs.