Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tgi xeon tag #641

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix tgi xeon tag #641

merged 1 commit into from
Aug 21, 2024

Conversation

Spycsh
Copy link
Collaborator

@Spycsh Spycsh commented Aug 21, 2024 •
edited by chensuyue
Loading

Description

fix tgi xeon tag

Issues

#636

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

All UT

@chensuyue chensuyue added this to the v0.9 milestone Aug 21, 2024
@eero-t
Copy link
Contributor

eero-t commented Aug 21, 2024

Using sha's is rather annoying, it does not tell user anything about whether its a stable or unstable version, is it recent or ancient etc.

@chensuyue
Copy link
Collaborator

Using sha's is rather annoying, it does not tell user anything about whether its a stable or unstable version, is it recent or ancient etc.

Because 2.2.0 didn't include the optimization we need, so we will use this sha version temperately, and will switch to 2.3.0 after it's release.

@chensuyue
Copy link
Collaborator

chensuyue commented Aug 21, 2024 •
edited
Loading

The CI issue caused by test structure update, can be fix and test in another PR. @daisy-ycguo

@chensuyue chensuyue merged commit 6674832 into opea-project:main Aug 21, 2024
35 of 40 checks passed
@lvliang-intel lvliang-intel mentioned this pull request Sep 11, 2024
Closed
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
@Spycsh @dmsuehir
fix tgi xeon tag (opea-project#641)
a8543d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@letonghan letonghan letonghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@Spycsh @eero-t @chensuyue @lvliang-intel @letonghan