Solving issues #5 and #6 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutson
reviewed
Dec 1, 2022
poetry_audit_plugin/command.py
Outdated
| ignored_vulns = 0 | ||
| for vulner in vulnerabilities: | ||
| if self.option("ignore-package"): | ||
| ignored_packages = self.option("ignore-package").split(',') |
There was a problem hiding this comment.
pls avoid re-evaluating this on each iteration.
dgutson
reviewed
Dec 1, 2022
poetry_audit_plugin/command.py
Outdated
| @@ -131,6 +141,39 @@ def get_json_report(self, vulnerabilities: List[Vulnerability]) -> str: | |||
| } | |||
| return json.dumps(json_report_dict, indent=2) | |||
|
|
|||
| def get_suppressions(self): | |||
| ignored_packages, codes = None, None | |||
dgutson
reviewed
Dec 1, 2022
poetry_audit_plugin/command.py
Outdated
| ignored_vulns = 0 | ||
| ignored_packages, codes = self.get_suppressions() | ||
| for vulner in vulnerabilities: | ||
| if self.option("ignore-package"): |
dgutson
reviewed
Dec 1, 2022
poetry_audit_plugin/command.py
Outdated
| if vulner.name in ignored_packages: | ||
| ignored_vulns += 1 | ||
| continue | ||
| if self.option("ignore-code"): |
dgutson
reviewed
Dec 1, 2022
tests/test_main.py
Outdated
|
|
||
| assert dev_vulnerability in vulnerabilitie_names | ||
| assert "ansible-tower-cli" not in vulnerabilitie_names | ||
| assert result.returncode == 1 |
|
@Franco0700 |
|
@dgutson |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I added a message where it says the amount of ignored vulnerabilities.